-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Update common_engine_methods_and_macros.rst #11339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Paperomo
wants to merge
6
commits into
godotengine:master
Choose a base branch
from
Paperomo:update-common_engine_methods_and_macros.rst
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update common_engine_methods_and_macros.rst #11339
Paperomo
wants to merge
6
commits into
godotengine:master
from
Paperomo:update-common_engine_methods_and_macros.rst
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the .cstr() function on String appears to be removed. code does not compile when used in a C++ Module. in 4.5
Ivorforce
approved these changes
Oct 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me. The modern version of c_str() is .utf8().get_data(), but I don't this is important in the context of format strings.
Calinou
reviewed
Oct 6, 2025
|
Updated with @Calinou 's suggestion |
Ivorforce
approved these changes
Nov 3, 2025
engine_details/architecture/common_engine_methods_and_macros.rst
Outdated
Show resolved
Hide resolved
oops Co-authored-by: Lukas Tenbrink <lukas.tenbrink@gmail.com>
Calinou
approved these changes
Nov 4, 2025
Calinou
reviewed
Nov 4, 2025
engine_details/architecture/common_engine_methods_and_macros.rst
Outdated
Show resolved
Hide resolved
Calinou
reviewed
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:engine details
Issues and PRs related to the Engine Details section of the documentation
cherrypick:4.4
cherrypick:4.5
enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the .cstr() function on String appears to be removed. code does not compile when used in a C++ Module. in 4.5