[DRAFT] Add api_version build option to select the API JSON file
#1897
Conversation
dsnopek
added
the
enhancement
dsnopek
force-pushed
the
select-api-version
branch
from
cc23464 to
8375226
Compare
dsnopek
force-pushed
the
select-api-version
branch
2 times, most recently
from
7df6252 to
9f0acbf
Compare
|
I've updated the CI so that it'll build for each supported API version (only 4.5 and 4.6 in this PR - more are added in the follow-up PRs), and then run the tests using each supported version of Godot. So, if it builds for 4.6, it just tests that against This is all I plan to add to this PR, however, it'll remain marked as DRAFT because the PR it depends on still isn't merged. |
dsnopek
force-pushed
the
select-api-version
branch
from
9f0acbf to
799e4aa
Compare
|
Turns out I had one more thing to add: cmake support! Seems to work in my testing, but I really don't know what I'm doing with cmake :-) cc @enetheru |
Looks good to me. None of the changes to CMake add additional complexity, nothing raises my eyebrows. :) |
2 participants
This builds on top of #1895, and is a replacement for our usual update of the
extension_api.jsonfile for Godot 4.6 (which we usually start doing at -beta1, so this also adds theextension_api.jsonfile for 4.6-beta1)The idea, is that we'll include
extension_api.jsonfiles for all the Godot versions that godot-cpp v10 is compatible with, and developers can specifyscons api_version=4.5(for example) to select an earlier API version. This is something that other GDExtension bindings do as well, for example, the Rust bindings.This is marked as a DRAFT because it depends on #1895 (the first godot-cpp v10 PR) which allows godot-cpp to be compatible with either Godot 4.5 or 4.6