Skip to content

Conversation

@AnthonyLedesma
Copy link
Member

@AnthonyLedesma AnthonyLedesma commented Apr 29, 2024

Description

The Site Design component has some logic that is responsible for moving Style elements. Changes in versions of WordPress over time had made the previous logic incompatible.

Screenshots

Before
Screenshot 2024-04-29 at 2 35 20 PM

After
Screenshot 2024-04-29 at 2 38 49 PM

Types of changes

Changes here to selectors. This change should prevent the same error from occurring in the future.

How has this been tested?

Tested manually in Managed WordPress hosting.

Acceptance criteria

Should resolve the error with Site Design in the post editor.

Checklist:

  • My code is tested
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

@AnthonyLedesma AnthonyLedesma self-assigned this Apr 29, 2024
@AnthonyLedesma AnthonyLedesma added this to the Next Release milestone Apr 29, 2024
Copy link
Contributor

@EvanHerman EvanHerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants