enable the lightbox script to load for all CoBlocks galleries#2589
Merged
AnthonyLedesma merged 1 commit intomasterfrom Feb 27, 2024
Merged
enable the lightbox script to load for all CoBlocks galleries#2589AnthonyLedesma merged 1 commit intomasterfrom
AnthonyLedesma merged 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2571
Not all galleries properly listed the 'Lightbox' script to load under the 'viewScript' block.json property. Adding the script allows the Lightbox to function as expected with all CoBlocks galleries.
Screenshots
Types of changes
Change here to block.json to allow for proper loading of the 'lightbox-script'.
How has this been tested?
Tested manually.
Acceptance criteria
Should allow the Lightbox on all CoBlocks galleries if only that single gallery is present on the page or all of them. Each block now ensures the script is loaded.
Checklist: