Compatibility with WP 6.4 #2568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
RichText multiline prop was deprecated. We seem to be using multiline props in a few places. Might need refactors here. Probably related to refactoring: |
Contributor
Author
olafleur-godaddy
left a comment
olafleur-godaddy
left a comment
There was a problem hiding this comment.
Nice job!
AnthonyLedesma
approved these changes
Oct 31, 2023
Member
AnthonyLedesma
left a comment
AnthonyLedesma
left a comment
There was a problem hiding this comment.
A complete test matrix has been established and is passing with these modifications.
https://github.com/godaddy-wordpress/coblocks/actions/runs/6709822699
Member
|
I found a quick CSS fix, that I will be pushing up without letting the tests all run again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshots
Types of changes
How has this been tested?
Acceptance criteria
Checklist: