Skip to content

Update form block save for WordPress 6.3 #2543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2023
Merged

Update form block save for WordPress 6.3 #2543

merged 1 commit into from
Jul 28, 2023

Conversation

@eherman-godaddy
Copy link
Collaborator

@eherman-godaddy eherman-godaddy commented Jul 28, 2023 •
edited by EvanHerman
Loading

Description

  • Update the form block save for WordPress 6.3 compatibility.
  • Updated the caniuse database version.

Types of changes

Bug fix (non-breaking change which fixes an issue)

How has this been tested?

  • Manually tested a migration from 6.2 with an existing form to 6.3 with the same form.
  • Manually tested setting up a new form in both 6.2 and 6.3.

Acceptance criteria

  • Form should load in the editor without any validation errors, and show up on the front of site.
  • No visible changes between WordPress 6.2 and 6.3.

Checklist:

  • My code is tested
  • I've added proper labels to this pull request

@eherman-godaddy eherman-godaddy added the [Type] Enhancement Something new that adds functionality label Jul 28, 2023
@eherman-godaddy eherman-godaddy requested a review from snovosel July 28, 2023 15:07
@eherman-godaddy eherman-godaddy self-assigned this Jul 28, 2023
@eherman-godaddy eherman-godaddy marked this pull request as ready for review July 28, 2023 15:20
@snovosel-godaddy snovosel-godaddy self-requested a review July 28, 2023 15:22
snovosel-godaddy
snovosel-godaddy approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@snovosel-godaddy snovosel-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvanHerman EvanHerman merged commit e744d3b into master Jul 28, 2023
@EvanHerman EvanHerman deleted the form-block-6.3 branch July 28, 2023 15:23
@EvanHerman
Copy link
Contributor

EvanHerman commented Jul 28, 2023

I'm going to look into why the unit tests aren't running in a separate PR.

@AnthonyLedesma
Copy link
Member

AnthonyLedesma commented Jul 28, 2023

Is a little concerning to see the E2E failures here, especially the Form block. Seems like it may be a temporary issue luckily.

@AnthonyLedesma AnthonyLedesma added this to the 3.1.0 milestone Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snovosel snovosel Awaiting requested review from snovosel

1 more reviewer

@snovosel-godaddy snovosel-godaddy snovosel-godaddy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@EvanHerman EvanHerman

Labels

[Type] Enhancement Something new that adds functionality

Projects

None yet

Milestone

3.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@eherman-godaddy @EvanHerman @AnthonyLedesma @snovosel-godaddy