Repository navigation
fix(update): show the update notice to scripts and AI assistants - #346
Open
jpage-godaddy wants to merge 1 commit into
Open
jpage-godaddy wants to merge 1 commit into
jpage-godaddy wants to merge 1 commit into
Conversation
The "new version available" notice was only printed when both stdout and stderr were terminals, so scripts and AI assistants, which run gddy with piped output, never learned that an update existed. The notice now goes to stderr on every run once a newer release is known, leaving stdout and its JSON untouched. When output is not a terminal it adds an "AI assistants:" line asking them to tell the user and to run `gddy update apply` only after the user agrees. It is still skipped in CI. The gddy skill now tells assistants to run `gddy update check` at the start of a session, to watch stderr for the notice, and to ask before updating. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
jpage-godaddy
requested review from
axburgess-godaddy,
jpearlman-godaddy,
mguerrero3-godaddy,
qcai-godaddy and
rts1-godaddy
as code owners
October 22, 2026 16:50
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes preserve stdout and CI suppression, with no identified blocking issues.
No open issues 🎉
What changed in this PR
This PR makes cached update notices visible to scripts and AI assistants while keeping command results on stdout unchanged.
Changes:
- Prints update notices to stderr for both terminal and piped output, while retaining CI suppression.
- Adds consent guidance for AI assistants in non-interactive notices and tests the notice text.
- Updates the
gddyskill to recommend checking for updates at session start and requesting permission before installing.
| File | Description |
|---|---|
rust/src/update/mod.rs |
Broadens notice visibility, adds assistant guidance, and tests interactive and piped notice text. |
.agents/skills/gddy/SKILL.md |
Documents session-start update checks and permission-based installation. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "new version available" notice was only printed when both stdout and stderr were terminals, so scripts and AI assistants, which run
gddywith piped output, never learned that an update existed.AI assistants:line asking them to tell the user and to rungddy update applyonly after the user agrees.CI/GITHUB_ACTIONS), where updating in place is pointless.gddyskill now tells assistants to rungddy update checkat the start of a session, to read stderr for the notice, and to ask before updating.Notes
The notice appears on every invocation until the update is applied, so anything that merges stderr into stdout will see it.
🤖 Generated with Claude Code