Repository navigation
fix(hosting): mark app-type and hosting-product as required in help - #345
Open
jhenderson1-godaddy wants to merge 1 commit into
Open
jhenderson1-godaddy wants to merge 1 commit into
jhenderson1-godaddy wants to merge 1 commit into
Conversation
…Label both flags '(required)' in --help and add a test that pins it.
jhenderson1-godaddy
marked this pull request as ready for review
October 22, 2026 13:33
jhenderson1-godaddy
requested review from
apetrovic-godaddy,
axburgess-godaddy,
jpage-godaddy,
jpearlman-godaddy,
mguerrero3-godaddy,
qcai-godaddy and
rts1-godaddy
as code owners
October 22, 2026 13:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--app-typeand--hosting-productare required, but--helplisted them like optional flags. This labels them "(required)" in their help entries and adds a test so the label stays in place.Why
The API requires
appTypeandhostingProduct, and the CLI rejects a missing value. The usage line shows the flag outside[OPTIONS], but the options block gave no sign of it.--app-typewas also described as "Hosting product", which reads like--hosting-producton the other command.Changes
--app-typeonhosting app listandhosting app create, and--hosting-productonhosting subscription list, now read "(required)" in--help.--app-typeis described as the application type. Thehosting appgroup help says "application type" too.app listandsubscription listdescriptions. The value list copied by hand into--hosting-productis removed as well, since clap prints the possible values itself.app list,app createandsubscription listwithout the flag. It checks that each fails and that its--helpentry says "(required)". The CLI helpers it uses moved from theapp createtests intohosting/test_support.rs.Not in this PR
Other feedback suggested two things, and neither of them is included here.
cli-engineprints it as is, so this needs a change incli-engine. An invalid value already lists the options.hosting app listwith no flag would either fail or default toNODEJSand hide WordPress apps from the list, so I kept the flag required. This one is open for discussion.Tested
Run on this branch:
cargo fmt --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspacecheck-module-size.sh