Repository navigation
fix(domain): label renewal prices as auto-renewal prices - #341
Open
jpage-godaddy wants to merge 1 commit into
Open
jpage-godaddy wants to merge 1 commit into
jpage-godaddy wants to merge 1 commit into
Conversation
The renewal price returned for domains reflects auto-renewal pricing; manual renewals can cost more and no manual price is available. Rename the table columns in `domain available`, `domain suggest` and `domain quote` so the figure isn't read as the price of every renewal. JSON field names are unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
jpage-godaddy
requested review from
axburgess-godaddy,
jpearlman-godaddy,
mguerrero3-godaddy,
qcai-godaddy and
rts1-godaddy
as code owners
October 21, 2026 15:49
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes only update display labels, match the stated scope, and preserve scripting interfaces.
No open issues 🎉
What changed in this PR
Clarifies that domain renewal prices apply to auto-renewal, not manual renewal.
Changes:
- Updates table headers to say “Auto-Renewal”.
- Preserves JSON keys and
--fieldsnames for script compatibility.
| File | Description |
|---|---|
| rust/src/domain/suggest.rs | Relabels one- and two-year auto-renewal columns. |
| rust/src/domain/quote.rs | Relabels the auto-renewal price column. |
| rust/src/domain/available.rs | Relabels the auto-renewal price column. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The renewal price the domains service returns is the price for an auto-renewal. Manual renewals can cost more, and no manual renewal price is available. The tables previously labelled this figure just "Renewal", which could be read as the price of any renewal.
The column headers now say "Auto-Renewal":
domain available: "Renewal Price" → "Auto-Renewal Price"domain quote: "Renewal Price" → "Auto-Renewal Price"domain suggest: "1yr Renewal" / "2yr Renewal" → "1yr Auto-Renewal" / "2yr Auto-Renewal"JSON output and
--fieldsnames (renewalPrice,renewalPrice1Year,renewalPrice2Year) are unchanged, so existing scripts keep working.shoppingoutput has its own "Renews:" label from a different service; it is not changed here.Test plan
cargo clippy --workspace -- -D warningscargo test --workspace🤖 Generated with Claude Code