*: drop goproxy dependency #1799
Open
+122
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferhatelmas
changed the title
ferhatelmas
force-pushed
the
proxy
branch
2 times, most recently
from
239a04c to
c71304b
Compare
ferhatelmas
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the test infrastructure by replacing the external github.com/elazarl/goproxy dependency with a custom minimal HTTP/HTTPS proxy implementation using only Go's standard library. This aligns with the library's goal of minimizing dependencies, as the proxy was only used in tests.
Key Changes:
- Implemented a custom
testProxytype with HTTP and HTTPS (CONNECT) proxying capabilities - Removed the
github.com/elazarl/goproxydependency from go.mod and go.sum - Unified the
setupHTTPProxyandsetupHTTPSProxyfunctions into a singlenewTestProxyconstructor
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| plumbing/transport/http/proxy_test.go | Replaced goproxy dependency with custom testProxy implementation that handles both HTTP and HTTPS (CONNECT) proxy requests |
| go.mod | Removed github.com/elazarl/goproxy dependency |
| go.sum | Removed goproxy dependency checksums |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ferhatelmas
force-pushed
the
proxy
branch
5 times, most recently
from
8d0073a to
77b773f
Compare
Member
|
@ferhatelmas overall LGTM. Please rebase. Relates to #1413. |
Assuming go-git is a library and so it's better to use minimal dependencies. github.com/elazarl/goproxy is only used by tests, adding a tiny implementation enables us to drop it. Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
Contributor
Author
|
@pjbgf rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming go-git is a library and so it's better to use minimal dependencies. github.com/elazarl/goproxy is only used by tests, adding a tiny implementation enables us to drop it.