Skip to content

Switch to FlorianRhiem/pyGLFW.#121

Open
wpk- wants to merge 1 commit intoglumpy:masterfrom
wpk-:pyGLFW
Open

Switch to FlorianRhiem/pyGLFW.#121
wpk- wants to merge 1 commit intoglumpy:masterfrom
wpk-:pyGLFW

Conversation

@wpk-
Copy link
Contributor

@wpk- wpk- commented Sep 18, 2017

From my last pull request I got the impression you're happy to move to this pyGLFW implementation. So this commit should do that.
I ran most of the examples and they work fine with glfw backend.
Let me know if it needs changes.

@rougier
Copy link
Member

rougier commented Sep 18, 2017

Thanks. I need to test it. Did you run all the "app-*" example ? This might be the most problematic ones. Also, can you remind me github repo for pyglfw ?

The pyglfw should be added in the setup file.

@wpk-
Copy link
Contributor Author

wpk- commented Sep 18, 2017

When running app-interactive.py it wouldn't let me type anything as it closed the window straight away and exited. All other app-examples seem to run fine. (the expected behaviour is not always documented but I think it looks good).

The repo for pyGLFW is https://github.com/FlorianRhiem/pyGLFW

Regarding the setup file, I have zero experience with that. Would greatly appreciate any help going about adding to it. (Looking at it though, I am not sure about adding glfw because it is optional anyway).

@wpk-
Copy link
Contributor Author

wpk- commented Sep 18, 2017

(to be clear, the behaviour of app-interactive.py I described above is the same as the current master branch, so not broken by the update but perhaps by something else)

@wpk-
Copy link
Contributor Author

wpk- commented Sep 28, 2017

@rougier, please let me know if there are specific things you'd like tested/changed.

@rougier rougier self-assigned this Oct 1, 2017
@rougier
Copy link
Member

rougier commented Oct 1, 2017

Sorry for the delay. It looks good, I only need to test it (and I lack time).
Please ping me here if your PR is no merged by end of next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants