Use gitoxide in get_status - #2673
Merged
Merged
Conversation
cruessler
force-pushed
the
use-gitoxide-for-status
branch
from
June 29, 2025 15:06
2916a78 to
1b3694b
Compare
cruessler
commented
Jun 29, 2025
With this change, when `get_status` is run in a sub-directory, it also returns matches in sub-directories that don鈥檛 share a prefix with the sub-directory it is being run in.
extrawurst
reviewed
Jul 6, 2025
extrawurst
reviewed
Jul 6, 2025
extrawurst
reviewed
Jul 6, 2025
extrawurst
reviewed
Jul 6, 2025
extrawurst
left a comment
extrawurst
left a comment
Collaborator
There was a problem hiding this comment.
just a few questions and nits, other looks good to go to me
Collaborator
Author
Great suggestions! I鈥檝e added them as items to the tracking issue to unblock this PR. Also, I鈥檝e already implemented one of them. :-) |
Collaborator
Author
|
@extrawurst This PR is ready from my side! Do you want further changes before it is merged? |
extrawurst
enabled auto-merge (squash)
July 27, 2025 15:20
Collaborator
|
@cruessler no sorry for the delay! looks good to me! 馃コ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update 2025-07-06
I鈥檝e been using this branch daily for the last week. I found one issue that I鈥檝e addressed in a separate commit. I think it鈥檚 now ready for review!
Initial description
This is a draft PR. I think that, at this point, most of the initial work of porting is done. I鈥檓 going to be using this branch as my daily driver throughout the week to find any issues there might still be left. I鈥檓 planning on marking it as ready for review at the end of the week.
This PR changes
asyncgit::sync::get_statusto usegitoxide. As a side-effect, it letsgitoxidehandle readingstatus.showUntrackedFiles. The resulting behaviour, with respect tostatus.showUntrackedFiles, is closer to what git does than it was before this PR. I鈥檝e updated 2 tests according to the new behaviour.