CS-15024: NullPointerException thrown while executing GetVmStatsCommand

Vijayendra Bhamidipati · Vijayendra Bhamidipati · commit 9fcdfe5b19f2 · 2012-05-25T18:24:02.000-07:00
Description:

	Fixing incorrect non-null object check.
diff --git a/core/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java b/core/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
@@ -4194,7 +4194,7 @@ public synchronized VmwareContext getServiceContext(Command cmd) {
 
     @Override
     public synchronized void invalidateServiceContext(VmwareContext context) {
-        if (_serviceContext == null) {
+        if (_serviceContext != null) {
             _serviceContext.close();
         }
         _serviceContext = null;

Original file line number	Diff line number	Diff line change
`@@ -4194,7 +4194,7 @@ public synchronized VmwareContext getServiceContext(Command cmd) {`
`4194`	`4194`
`4195`	`4195`	`@Override`
`4196`	`4196`	`public synchronized void invalidateServiceContext(VmwareContext context) {`
`4197`		`- if (_serviceContext == null) {`
	`4197`	`+ if (_serviceContext != null) {`
`4198`	`4198`	`_serviceContext.close();`
`4199`	`4199`	`}`
`4200`	`4200`	`_serviceContext = null;`