CLOUDSTACK-5989: Trying to start a vm while 'vm snapshot' is in progress results in inconsistency

koushik-das · koushik-das · commit 580ebb0010cb · 2014-01-31T10:39:43.000+05:30
The fix is to fail the start operation if a vm snapshot is in progress
diff --git a/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java b/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
@@ -1525,6 +1525,11 @@ private void setStateMachine() {
     }
 
     protected boolean stateTransitTo(VMInstanceVO vm, VirtualMachine.Event e, Long hostId, String reservationId) throws NoTransitionException {
+        // if there are active vm snapshots task, state change is not allowed
+        if (_vmSnapshotMgr.hasActiveVMSnapshotTasks(vm.getId())) {
+            s_logger.error("State transit with event: " + e + " failed due to: " + vm.getInstanceName() + " has active VM snapshots tasks");
+            return false;
+        }
         vm.setReservationId(reservationId);
         return _stateMachine.transitTo(vm, e, new Pair<Long, Long>(vm.getHostId(), hostId), _vmDao);
     }

Original file line number	Diff line number	Diff line change
`@@ -1525,6 +1525,11 @@ private void setStateMachine() {`
`1525`	`1525`	`}`
`1526`	`1526`
`1527`	`1527`	`protected boolean stateTransitTo(VMInstanceVO vm, VirtualMachine.Event e, Long hostId, String reservationId) throws NoTransitionException {`
	`1528`	`+ // if there are active vm snapshots task, state change is not allowed`
	`1529`	`+ if (_vmSnapshotMgr.hasActiveVMSnapshotTasks(vm.getId())) {`
	`1530`	`+ s_logger.error("State transit with event: " + e + " failed due to: " + vm.getInstanceName() + " has active VM snapshots tasks");`
	`1531`	`+ return false;`
	`1532`	`+ }`
`1528`	`1533`	`vm.setReservationId(reservationId);`
`1529`	`1534`	`return _stateMachine.transitTo(vm, e, new Pair<Long, Long>(vm.getHostId(), hostId), _vmDao);`
`1530`	`1535`	`}`