CLOUDSTACK-3206. CreateVlanIpRange fails with IndexOutOfBoundsException.

Likitha Shetty · Likitha Shetty · commit 55f0e167ecda · 2013-06-26T14:59:36.000+05:30
diff --git a/server/src/com/cloud/configuration/ConfigurationManagerImpl.java b/server/src/com/cloud/configuration/ConfigurationManagerImpl.java
@@ -2685,8 +2685,8 @@ public Vlan createVlanAndPublicIpRange(CreateVlanIpRangeCmd cmd) throws Insuffic
                 }
 
                 List<VlanVO> vlans = _vlanDao.listVlansByNetworkId(network.getId());
-                VlanVO vlan = vlans.get(0);
                 if (vlans != null && vlans.size() > 0) {
+                    VlanVO vlan = vlans.get(0);
                     if (vlanId == null) {
                         vlanId = vlan.getVlanTag();
                     } else if (!vlan.getVlanTag().equals(vlanId)) {

Original file line number	Diff line number	Diff line change
`@@ -2685,8 +2685,8 @@ public Vlan createVlanAndPublicIpRange(CreateVlanIpRangeCmd cmd) throws Insuffic`
`2685`	`2685`	`}`
`2686`	`2686`
`2687`	`2687`	`List<VlanVO> vlans = _vlanDao.listVlansByNetworkId(network.getId());`
`2688`		`- VlanVO vlan = vlans.get(0);`
`2689`	`2688`	`if (vlans != null && vlans.size() > 0) {`
	`2689`	`+ VlanVO vlan = vlans.get(0);`
`2690`	`2690`	`if (vlanId == null) {`
`2691`	`2691`	`vlanId = vlan.getVlanTag();`
`2692`	`2692`	`} else if (!vlan.getVlanTag().equals(vlanId)) {`