Skip to content

Commit 3d369de

Browse files
author
SrikanteswaraRao Talluri
committed
CLOUDSTACK-7388: removed host credentials in the services dict.
1 parent aa64d8b commit 3d369de

1 file changed

Lines changed: 27 additions & 19 deletions

File tree

test/integration/component/maint/test_redundant_router.py

Lines changed: 27 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -94,11 +94,6 @@ def __init__(self):
9494
},
9595
},
9696
},
97-
"host": {
98-
"username": "root",
99-
"password": "password",
100-
"publicport": 22,
101-
},
10297
"network": {
10398
"name": "Test Network",
10499
"displaytext": "Test Network",
@@ -854,15 +849,21 @@ def test_redundantVR_internals(self):
854849
hypervisor=self.hypervisor
855850
)
856851
else:
857-
result = get_process_status(
858-
master_host.ipaddress,
859-
self.services['host']["publicport"],
860-
self.services['host']["username"],
861-
self.services['host']["password"],
862-
master_router.linklocalip,
863-
'ip addr show eth2'
852+
try:
853+
host = {}
854+
host.user, host.passwd = get_host_credentials(self.config, master_host.ipaddress)
855+
result = get_process_status(
856+
master_host.ipaddress,
857+
22,
858+
host.user,
859+
host.passwd,
860+
master_router.linklocalip,
861+
"ip addr show eth2"
864862
)
865863

864+
except KeyError:
865+
self.skipTest("Marvin configuration has no host credentials to check router services")
866+
866867
res = str(result)
867868

868869
self.debug("Command 'ip addr show eth2': %s" % result)
@@ -890,14 +891,21 @@ def test_redundantVR_internals(self):
890891
hypervisor=self.hypervisor
891892
)
892893
else:
893-
result = get_process_status(
894-
backup_host.ipaddress,
895-
self.services['host']["publicport"],
896-
self.services['host']["username"],
897-
self.services['host']["password"],
898-
backup_router.linklocalip,
899-
'ip addr show eth2',
894+
try:
895+
host = {}
896+
host.user, host.passwd = get_host_credentials(self.config, backup_host.ipaddress)
897+
result = get_process_status(
898+
master_host.ipaddress,
899+
22,
900+
host.user,
901+
host.passwd,
902+
backup_router.linklocalip,
903+
"ip addr show eth2"
900904
)
905+
906+
except KeyError:
907+
self.skipTest("Marvin configuration has no host credentials to check router services")
908+
901909
res = str(result)
902910

903911
self.debug("Command 'ip addr show eth2': %s" % result)

0 commit comments

Comments
 (0)