.submodules leads to IndexError: list index out of range on info = self._cache[item] #613

Activity

1. Byron commented on Apr 9, 2017

   

   Byron

   on Apr 9, 2017

   Member

   More actions

   Thanks for letting me know. I assume that the original repository that is showing the issue is not public, so we are left with an issue that is not reproducible.
   What do you suggest we should do?
2. Byron

   added

   waiting for feedback

   on Apr 9, 2017
3. yarikoptic commented on Apr 9, 2017

   

   yarikoptic

   on Apr 9, 2017

   ContributorAuthor

   More actions

   eh -- took me a while to find that repo where I originally ran into it (again blaming myself for not quoting enough info for myself)... found it -- now you can get the entirety of it in its dirty state from http://www.onerussian.com/tmp/phsyionet-challenge.tar.gz
4. Byron

   added

   acknowledged

   and removed

   waiting for feedback

   on Apr 9, 2017
5. Byron commented on Apr 9, 2017

   

   Byron

   on Apr 9, 2017

   Member

   More actions

   @yarikoptic Thanks for taking the time to look - I pulled the file and was able to easily reproduce the issue. Just to be on the safe side, I put it into a gist.

   This is how to reproduce the issue, assuming you have gitpython in your PYTHON_PATH:

   set -e
   curl https://gist.githubusercontent.com/Byron/17073cdb4c3019675d34a4705339e962/raw/802129991aa0bd2c23ee0f600b2ec4cef88ffbad/challenge.base64.zip | base64 -D > challenge.zip
   unzip challenge.zip
   (cd challenge && python -c 'from git import Repo; print Repo(".").submodules')
6. yarikoptic commented on Sep 7, 2017

   

   yarikoptic

   on Sep 7, 2017

   ContributorAuthor

   More actions

   In datalad/datalad#1801 we ran into our datalad crashing because we used GitPython's parser for .gitmodules and used get_value which automagically casts values into int and bool whenever it could. We fixed it on our end, but then decided to test more... Now I have managed to reproduce both crashes -- the one we have in that datalad issue (when I use bool value for the name) and this one (when I use numeric), so I guess the reason could be the same "misuse" of get_value (casts) whenever get should have been used (no casting):

   clean run:

   $> s=s123; builtin cd /tmp/; rm -rf /tmp/gitsub; mkdir /tmp/gitsub; cd /tmp/gitsub; git init; mkdir $s; cd $s; git init; touch 1; git add 1; git commit -m msg 1; cd ..; git submodule add ./$s $s; git add .gitmodules; git commit -m "added subm $s" 
   Initialized empty Git repository in /tmp/gitsub/.git/
   Initialized empty Git repository in /tmp/gitsub/s123/.git/
   [master (root-commit) 2b57b47] msg
    1 file changed, 0 insertions(+), 0 deletions(-)
    create mode 100644 1
   s123/
   Adding existing repo at 's123' to the index
   [master (root-commit) 8990a73] added subm s123
    2 files changed, 4 insertions(+)
    create mode 100644 .gitmodules
    create mode 160000 s123
   2 10278.....................................:Thu 07 Sep 2017 12:11:07 PM EDT:.
   (git)hopa:/tmp/gitsub[master]git
   $> python -c 'import git; r=git.Repo("."); print(r.submodules)'
   [git.Submodule(name=s123, path=s123, url=./s123, branch_path=refs/heads/master)]

   int:

   2 10279.....................................:Thu 07 Sep 2017 12:11:10 PM EDT:.
   (git)hopa:/tmp/gitsub[master]git
   $> s=123; builtin cd /tmp/; rm -rf /tmp/gitsub; mkdir /tmp/gitsub; cd /tmp/gitsub; git init; mkdir $s; cd $s; git init; touch 1; git add 1; git commit -m msg 1; cd ..; git submodule add ./$s $s; git add .gitmodules; git commit -m "added subm $s" 
   Initialized empty Git repository in /tmp/gitsub/.git/
   Initialized empty Git repository in /tmp/gitsub/123/.git/
   [master (root-commit) 8297bb7] msg
    1 file changed, 0 insertions(+), 0 deletions(-)
    create mode 100644 1
   123/
   Adding existing repo at '123' to the index
   [master (root-commit) 3417128] added subm 123
    2 files changed, 4 insertions(+)
    create mode 100644 .gitmodules
    create mode 160000 123
   2 10280.....................................:Thu 07 Sep 2017 12:11:13 PM EDT:.
   (git)hopa:/tmp/gitsub[master]git
   $> python -c 'import git; r=git.Repo("."); print(r.submodules)'
   Traceback (most recent call last):                             
     File "<string>", line 1, in <module>
     File "/usr/lib/python2.7/dist-packages/git/repo/base.py", line 293, in submodules
       return Submodule.list_items(self)
     File "/usr/lib/python2.7/dist-packages/git/util.py", line 932, in list_items
       out_list.extend(cls.iter_items(repo, *args, **kwargs))
     File "/usr/lib/python2.7/dist-packages/git/objects/submodule/base.py", line 1181, in iter_items
       sm = rt[p]
     File "/usr/lib/python2.7/dist-packages/git/objects/tree.py", line 293, in __getitem__
       info = self._cache[item]
   IndexError: list index out of range
   

   bool:

   $> s=false; builtin cd /tmp/; rm -rf /tmp/gitsub; mkdir /tmp/gitsub; cd /tmp/gitsub; git init; mkdir $s; cd $s; git init; touch 1; git add 1; git commit -m msg 1; cd ..; git submodule add ./$s $s; git add .gitmodules; git commit -m "added subm $s"   
   Initialized empty Git repository in /tmp/gitsub/.git/
   Initialized empty Git repository in /tmp/gitsub/false/.git/
   [master (root-commit) 987d30b] msg
    1 file changed, 0 insertions(+), 0 deletions(-)
    create mode 100644 1
   false/
   Adding existing repo at 'false' to the index
   [master (root-commit) 12afd38] added subm false
    2 files changed, 4 insertions(+)
    create mode 100644 .gitmodules
    create mode 160000 false
   2 10282.....................................:Thu 07 Sep 2017 12:14:50 PM EDT:.
   (git)hopa:/tmp/gitsub[master]git
   $> python -c 'import git; r=git.Repo("."); print(r.submodules)'
   Traceback (most recent call last):                             
     File "<string>", line 1, in <module>
     File "/usr/lib/python2.7/dist-packages/git/repo/base.py", line 293, in submodules
       return Submodule.list_items(self)
     File "/usr/lib/python2.7/dist-packages/git/util.py", line 932, in list_items
       out_list.extend(cls.iter_items(repo, *args, **kwargs))
     File "/usr/lib/python2.7/dist-packages/git/objects/submodule/base.py", line 1194, in iter_items
       sm._name = n
   AttributeError: 'Blob' object has no attribute '_name'
   
7. yarikoptic

   closed this as completedin #667on Sep 21, 2017