File handles left open #287

Activity

1. Byron commented on May 12, 2015

   

   Byron

   on May 12, 2015

   Member

   More actions

   Thank you. Which Python version are you using?
   In python 3, destructors are usually not called, even if the Repo instance is deleted or goes out of scope.
2. Byron

   added this to the v1.0.2 - Fixes milestone on May 12, 2015
3. Byron

   added

   waiting for feedback

   on May 12, 2015
4. afgane commented on May 12, 2015

   

   afgane

   on May 12, 2015

   Author

   More actions

   This is on Python 2.7.6
5. Byron

   added

   acknowledged

   critical

   and removed

   waiting for feedback

   on May 12, 2015
6. Byron commented on May 12, 2015

   

   Byron

   on May 12, 2015

   Member

   More actions

   I didn't reproduce it yet, but can imagine this truly is the case.

   What happens if you delete your repo instance, e.g. with del repo? This should work on python 2.7 (but I didn't try it yet).
   You could also try repo.odb.release() to forcefully free all handles.

   If in any of the tests above the handles remain opened, this is indeed a critical and possibly easily reproducible bug.
7. afgane commented on May 12, 2015

   

   afgane

   on May 12, 2015

   Author

   More actions

   del repo unfortunately does nothing. This was the first thing I tried yesterday.

   repo.odb.release() does not exist? The following are the only members odb object shows:

   In [31]: r.odb.
   r.odb.LooseDBCls                   r.odb.databases                    r.odb.loose_dir                    r.odb.root_path                    r.odb.store
   r.odb.PackDBCls                    r.odb.db_path                      r.odb.ostream                      r.odb.set_ostream                  r.odb.stream
   r.odb.ReferenceDBCls               r.odb.has_object                   r.odb.packs_dir                    r.odb.sha_iter                     r.odb.update_cache
   r.odb.alternates_dir               r.odb.info                         r.odb.partial_to_complete_sha_hex  r.odb.size
   

   I've explored those but no progress.

   Thanks for looking into this.
8. Byron commented on May 13, 2015

   

   Byron

   on May 13, 2015

   Member

   More actions

   Apparently I was wrong about the release() method on the pure-python implementation of the Git database. However, there is a git-command based implementation which uses git cat-file to obtain object information. Whenever such a database is destroyed, the persistent commands will be shut down.

   To use it, just instantiate your Repo instance as follows:

   import git
   r = git.Repo(odbt=git.GitCmdObjectDB)
   r.commit().message
   # now lsof shows some pack files
   del r
   # now they are gone

   It's a bit sad that there seems to be no way to trigger this kind of resource release in the pure-python implementation, and considering that GitPython is in maintenance mode, I believe this is not going to improve.

   Please let me know if the suggested workaround did indeed work for you.
   Thanks
9. afgane commented on May 13, 2015

   

   afgane

   on May 13, 2015

   Author

   More actions

   This worked from the command prompt. I'll try it in the app a bit later.

   Thank you.
10. Byron commented on May 13, 2015

    

    Byron

    on May 13, 2015

    Member

    More actions

    Great to hear ! Feel free to close this issue if it worked in the app as well.
11. Byron

    added

    waiting for feedback

    and removed

    acknowledged

    critical

    on May 14, 2015
12. Byron commented on May 14, 2015

    

    Byron

    on May 14, 2015

    Member

    More actions

    You can watch the development stream on youtube.

    GitPython #1 [investigate resource leak]

    
13. afgane commented on May 14, 2015

    

    afgane

    on May 14, 2015

    Author

    More actions

    It's working in the larger context as well - thank you again for tracking this down and providing a workaround. (And thanks for capturing the process in the video.)
14. afgane

    closed this as completedon May 14, 2015
15. afgane

    added a commit that references this issue on May 22, 2015

    Fix GitPython repo interaction as per gitpython-developers/GitPython#287

    ...

    bb17688