Update Repo.config_reader to support user $HOME/.config/git/config #160

Activity

1. Byron

   added

   acknowledged

   on May 6, 2014
2. Byron

   added this to the v0.3.5 - bugfixes milestone on Nov 19, 2014
3. Byron

   self-assigned this

   on Jan 10, 2015
4. Byron

   closed this as completedin 597bc56on Jan 10, 2015
5. Byron commented on Jan 10, 2015

   

   Byron

   on Jan 10, 2015

   Member

   More actions

   You can see how this was implemented in this youtube video.
6. jzempel commented on Jan 11, 2015

   

   jzempel

   on Jan 11, 2015

   Author

   More actions

   @Byron thanks for the fix & the video. I think you're close. But it's not quite right.

   Your code would be looking for either $XDG_CONFIG_HOME/.config/git/config or $HOME/.config/git/config. Per the git documentation, it should be $XDG_CONFIG_HOME/git/config.

   Please see my Repo class override workaround for details: https://github.com/jzempel/continuity/blob/master/continuity/services/git.py#L38-L58
7. Byron

   added 2 commits that reference this issue on Jan 12, 2015

   Re-implemented 'user' config level based on suggestion by @jzempel

   ...

   This issue will close once commit acd8246 is merged into the 'main' branch.

   acd8246

   Added specific test for roughly checking configuration paths.

   ...

   This issue will close once commit dfb0a9c is merged into the 'main' branch.

   dfb0a9c
8. Byron commented on Jan 12, 2015

   

   Byron

   on Jan 12, 2015

   Member

   More actions

   Thanks a bunch - you are totally right and I have basically put in the code in your override. Additionally I had a look at the c-git source and it is indeed implemented similarly.