Add optional entry type option for tree entries#221
Merged
lyrixx merged 5 commits intogitonomy:mainfrom May 6, 2024
Merged
Conversation
Contributor
Author
|
@simonhamp I have updated a failing test from de32cc0 Could you double check that it is correct to fix it inside the test? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An example implementation for getting entries by type.
Not sure yet about the name and location of the enum, and even if it should be an enum.Made each type a separate function and removed the enum
Implementation of the idea in #220