Repository navigation
Conversation
Attach window handlers before renderer loading and track menubar visibility so tray actions stay synchronized.
Share language metadata with tooling and the main process without importing renderer initialization.
Route application-owned native text through a separate i18next instance and include it in extraction without changing English output.
Resolve and persist language in the main process before native UI and renderer startup, so both processes use the same authoritative preference.
github-actions
Bot
added
the
enhancement
This was referenced Nov 7, 2026
Tunglies
marked this pull request as ready for review
November 7, 2026 02:25
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the main process as the single source of truth for the application language so native UI and the renderer use the same preference from startup.
Resolve the preferred supported system language when no explicit choice is saved. Store explicit choices in
language.jsonunderuserData, and provide the resolved language through typed IPC before the renderer's first render.Persist a selection before applying it. If saving fails, retain the previous language. Refresh native menu labels and updater text while preserving window visibility, download progress, and update-prompt state.
Existing renderer-local language preferences are not migrated. Confirmed application reset clears the new preference; cancellation preserves it.
Blocked by:
Merge after both prerequisites have landed. #3651 can be reviewed and merged independently of this PR.
This Draft currently includes the prerequisite commits because all PRs target
main. Review the language lifecycle change separately in this comparison. The branch will be rebased after the prerequisites merge.Follow-up: #3619 adds Simplified Chinese support using this language lifecycle.