Repository navigation
Conversation
github-actions
Bot
added
the
enhancement
Tunglies
force-pushed
the
i18n-chinese-simpified
branch
from
November 4, 2026 10:37
6392205 to
cc73d61
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Tunglies
force-pushed
the
i18n-chinese-simpified
branch
4 times, most recently
from
November 5, 2026 00:15
f9e6090 to
61a4f55
Compare
Tunglies
marked this pull request as ready for review
November 5, 2026 00:17
Author
|
There you go @setchy |
Tunglies
force-pushed
the
i18n-chinese-simpified
branch
from
November 5, 2026 06:01
61a4f55 to
8976b80
Compare
setchy
requested changes
Nov 6, 2026
setchy
left a comment
setchy
left a comment
Member
There was a problem hiding this comment.
Thanks for working on the translations @Tunglies.
When ready, we may want to split this into a few separate smaller changes such as
- move i18n locales to shared
- support translate main
- support OS language sync
- simplified Chinese translation
- etc
Author
|
More smaller commit? I see. :） |
Member
independent PRs please. makes it easier to review and merge. If it was translation alone that is fine as a single PR, but all the other platform changes I think should be in their own independent PRs |
Tunglies
marked this pull request as draft
November 7, 2026 01:51
Attach window handlers before renderer loading and track menubar visibility so tray actions stay synchronized.
Share language metadata with tooling and the main process without importing renderer initialization.
Resolve application-generated descriptions at display time and pass the active locale to date rendering while preserving existing English wording.
Route application-owned native text through a separate i18next instance and include it in extraction without changing English output.
Resolve and persist language in the main process before native UI and renderer startup, so both processes use the same authoritative preference.
This was referenced Nov 7, 2026
Match explicit script tags before region hints so Traditional Chinese system preferences do not select Simplified Chinese. Ref gitify-app#1952
Tunglies
force-pushed
the
i18n-chinese-simpified
branch
from
November 7, 2026 02:22
8976b80 to
cf3749c
Compare
Tunglies
changed the title
Tunglies
marked this pull request as ready for review
November 7, 2026 02:25
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Simplified Chinese (
zh-Hans, 简体中文) for the renderer and application-owned native UI.Provide the translation resources, language registration, Chinese duration and plural handling, and locale-specific tests. Match explicit script tags before region hints so Traditional Chinese system preferences do not select Simplified Chinese.
Preserve existing English wording, interpolation variables, component tags, and user-provided content.
Blocked by:
Merge after both prerequisites have landed. Native UI translation support from #3652 is included through #3653.
This Draft currently includes the prerequisite commits because all PRs target
main. Review the Simplified Chinese change separately in this comparison. The branch will be rebased after the prerequisites merge.Related: #1952
Add Simplified Chinese localization support
Related: #1952
Nice to have: #3463
Assisted by GPT6(high-effort)
Human confirmed(or adjust) the accuracy of the translation as a native speaker.
Some infrastructure might changes as needed