Repository navigation
Conversation
Read the operating system's login-item state through a new GET_LOGIN_ITEM_SETTINGS IPC event and surface mismatches in System settings. macOS reports not-registered, enabled, requires-approval, or not-found; Windows reports whether the executable will launch at login. The read is skipped in development and on Linux to avoid false warnings.
|
setchy
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of OpenSpec change
04-clean-up-dependencies-and-electron-debt(tasks 2.2–2.5).GET_LOGIN_ITEM_SETTINGSto the typed IPC contract. The main handler returnsopenAtLoginplus macOSstatusor WindowsexecutableWillLaunchAtLogin, and skips the read in development and on Linux so a dev build cannot show a false warning.useLoginItemStatus, which reads on settings mount and re-reads on window focus. A failed read returnsnull, so the screen never claims the item is active.requires-approval,not-found,not-registered, or a disabled Windows startup entry.CONTRIBUTING.md.Verification
pnpm checkpasses.pnpm i18n:checkpasses with the new English keys.Notes
Draft for review. The contract cleanup in #3587 is separate; this PR is based on
mainand should merge cleanly after it.