Repository navigation
refactor: drop unsupported openAsHidden - #3587
Merged
Merged
Conversation
Electron 44 removed openAsHidden from the login-item settings. Send only openAtLogin from the preload and main handler, and assert the payload in the preload and handler tests.
setchy
changed the title
setchy
marked this pull request as ready for review
November 1, 2026 21:19
|
Contributor
|
🎉 This pull request is included in Gitify v8.0.0! 🎉 Downloads for macOS, Windows, and Linux are available on the release page. Thanks for helping make Gitify better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of OpenSpec change
04-clean-up-dependencies-and-electron-debt(task 2.1).Electron removed the
openAsHiddenlogin-item option — it only worked on macOS 12 and below, which Electron no longer supports. This drops it fromIAutoLaunchand the preload payload; the main handler now forwards onlyopenAtLogintoapp.setLoginItemSettings.Verification
pnpm checksrc/preload/index.test.ts— payload contains onlyopenAtLoginsrc/main/handlers/system.test.ts— onlyopenAtLoginreaches the OS