Fix services' type's isLiteral implementation (microsoft#50929)

gabritto · web-flow · commit fdcb2ffd1beb · 2022-11-02T11:28:10.000-07:00
* fix services' type's isLiteral

* update literal completions tests

* remove booleans from literals
diff --git a/src/services/services.ts b/src/services/services.ts
@@ -511,7 +511,7 @@ namespace ts {
             return !!(this.flags & TypeFlags.UnionOrIntersection);
         }
         isLiteral(): this is LiteralType {
-            return !!(this.flags & TypeFlags.StringOrNumberLiteral);
+            return !!(this.flags & (TypeFlags.StringLiteral | TypeFlags.NumberLiteral | TypeFlags.BigIntLiteral));
         }
         isStringLiteral(): this is StringLiteralType {
             return !!(this.flags & TypeFlags.StringLiteral);
diff --git a/tests/cases/fourslash/completionsLiterals.ts b/tests/cases/fourslash/completionsLiterals.ts
@@ -1,6 +1,7 @@
 /// <reference path="fourslash.ts" />
 
 ////const x: 0 | "one" = /**/;
+////const y: 0 | "one" | 1n = /*1*/;
 
 verify.completions({
     marker: "",
@@ -10,3 +11,12 @@ verify.completions({
     ],
     isNewIdentifierLocation: true,
 });
+verify.completions({
+    marker: "1",
+    includes: [
+        { name: "0", kind: "string", text: "0" },
+        { name: '"one"', kind: "string", text: '"one"' },
+        { name: "1n", kind: "string", text: "1n" },
+    ],
+    isNewIdentifierLocation: true,
+});

Original file line number	Diff line number	Diff line change
`@@ -511,7 +511,7 @@ namespace ts {`
`511`	`511`	`return !!(this.flags & TypeFlags.UnionOrIntersection);`
`512`	`512`	`}`
`513`	`513`	`isLiteral(): this is LiteralType {`
`514`		`- return !!(this.flags & TypeFlags.StringOrNumberLiteral);`
	`514`	`+ return !!(this.flags & (TypeFlags.StringLiteral \| TypeFlags.NumberLiteral \| TypeFlags.BigIntLiteral));`
`515`	`515`	`}`
`516`	`516`	`isStringLiteral(): this is StringLiteralType {`
`517`	`517`	`return !!(this.flags & TypeFlags.StringLiteral);`