Skip to content

Commit 679fbad

Browse files
author
Chad Little
committed
Remove PHUIDocumentView
Summary: Converts final call site to PHUIDocumentViewPro. Test Plan: grep for PHUIDocumentView, view new Welcome Page Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16379
1 parent 3a002b6 commit 679fbad

File tree

7 files changed

+16
-426
lines changed

7 files changed

+16
-426
lines changed

‎resources/celerity/map.php‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
'rsrc/css/application/conduit/conduit-api.css' => '7bc725c4',
4242
'rsrc/css/application/config/config-options.css' => '0ede4c9b',
4343
'rsrc/css/application/config/config-template.css' => '8e6c6fcd',
44-
'rsrc/css/application/config/config-welcome.css' => '6abd79be',
44+
'rsrc/css/application/config/config-welcome.css' => '035aa483',
4545
'rsrc/css/application/config/setup-issue.css' => 'db7e9c40',
4646
'rsrc/css/application/config/unhandled-exception.css' => '4c96257a',
4747
'rsrc/css/application/conpherence/durable-column.css' => '86396117',
@@ -131,7 +131,7 @@
131131
'rsrc/css/phui/phui-curtain-view.css' => '7148ae25',
132132
'rsrc/css/phui/phui-document-pro.css' => 'dc3d46ed',
133133
'rsrc/css/phui/phui-document-summary.css' => '9ca48bdf',
134-
'rsrc/css/phui/phui-document.css' => '715aedfb',
134+
'rsrc/css/phui/phui-document.css' => 'c32e8dec',
135135
'rsrc/css/phui/phui-feed-story.css' => 'aa49845d',
136136
'rsrc/css/phui/phui-fontkit.css' => '9cda225e',
137137
'rsrc/css/phui/phui-form-view.css' => 'fab0a10f',
@@ -546,7 +546,7 @@
546546
'changeset-view-manager' => 'a2828756',
547547
'conduit-api-css' => '7bc725c4',
548548
'config-options-css' => '0ede4c9b',
549-
'config-welcome-css' => '6abd79be',
549+
'config-welcome-css' => '035aa483',
550550
'conpherence-durable-column-view' => '86396117',
551551
'conpherence-menu-css' => 'f99fee4c',
552552
'conpherence-message-pane-css' => '5897d3ac',
@@ -835,7 +835,7 @@
835835
'phui-crumbs-view-css' => '9dac418c',
836836
'phui-curtain-view-css' => '7148ae25',
837837
'phui-document-summary-view-css' => '9ca48bdf',
838-
'phui-document-view-css' => '715aedfb',
838+
'phui-document-view-css' => 'c32e8dec',
839839
'phui-document-view-pro-css' => 'dc3d46ed',
840840
'phui-feed-story-css' => 'aa49845d',
841841
'phui-font-icon-base-css' => '6449bce8',

‎src/__phutil_library_map__.php‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1622,9 +1622,7 @@
16221622
'PHUIDiffTableOfContentsItemView' => 'infrastructure/diff/view/PHUIDiffTableOfContentsItemView.php',
16231623
'PHUIDiffTableOfContentsListView' => 'infrastructure/diff/view/PHUIDiffTableOfContentsListView.php',
16241624
'PHUIDiffTwoUpInlineCommentRowScaffold' => 'infrastructure/diff/view/PHUIDiffTwoUpInlineCommentRowScaffold.php',
1625-
'PHUIDocumentExample' => 'applications/uiexample/examples/PHUIDocumentExample.php',
16261625
'PHUIDocumentSummaryView' => 'view/phui/PHUIDocumentSummaryView.php',
1627-
'PHUIDocumentView' => 'view/phui/PHUIDocumentView.php',
16281626
'PHUIDocumentViewPro' => 'view/phui/PHUIDocumentViewPro.php',
16291627
'PHUIFeedStoryExample' => 'applications/uiexample/examples/PHUIFeedStoryExample.php',
16301628
'PHUIFeedStoryView' => 'view/phui/PHUIFeedStoryView.php',
@@ -6270,9 +6268,7 @@
62706268
'PHUIDiffTableOfContentsItemView' => 'AphrontView',
62716269
'PHUIDiffTableOfContentsListView' => 'AphrontView',
62726270
'PHUIDiffTwoUpInlineCommentRowScaffold' => 'PHUIDiffInlineCommentRowScaffold',
6273-
'PHUIDocumentExample' => 'PhabricatorUIExample',
62746271
'PHUIDocumentSummaryView' => 'AphrontTagView',
6275-
'PHUIDocumentView' => 'AphrontTagView',
62766272
'PHUIDocumentViewPro' => 'AphrontTagView',
62776273
'PHUIFeedStoryExample' => 'PhabricatorUIExample',
62786274
'PHUIFeedStoryView' => 'AphrontView',

‎src/applications/config/controller/PhabricatorConfigWelcomeController.php‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,7 @@ public function buildWelcomeScreen(AphrontRequest $request) {
358358
$quick_header = new PHUIRemarkupView(
359359
$viewer, pht('=Quick Start Guide'));
360360

361-
return id(new PHUIDocumentView())
361+
$document = id(new PHUIDocumentViewPro())
362362
->setHeader($header)
363363
->setFluid(true)
364364
->appendChild($setup_header)
@@ -367,6 +367,11 @@ public function buildWelcomeScreen(AphrontRequest $request) {
367367
->appendChild($explore)
368368
->appendChild($quick_header)
369369
->appendChild($quick);
370+
371+
return id(new PHUIBoxView())
372+
->setBorder(true)
373+
->appendChild($document)
374+
->addClass('mlb');
370375
}
371376

372377
private function newItem(AphrontRequest $request, $icon, $content) {

‎src/applications/uiexample/examples/PHUIDocumentExample.php‎

Lines changed: 0 additions & 199 deletions
This file was deleted.

0 commit comments

Comments
 (0)