Merge branch 'master' into swarm

KostyaSha · web-flow · commit b707758e32c3 · 2017-07-05T21:07:14.000+03:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,12 @@ Change Log
 ===
 ## (dev) 3.1.0 (reserverd for swarm features)
  
+ 
+## 3.0.12
+- Make NettyDockerCmdExecFactory has compatibility both Linux and OSX automatically
+- Fix double encoding for netty.
+- filter config.json before unmarshalling (creds/auth)
+
 ## 3.0.11
 - Add labels and attachable properties to network.
 - Set default socket timeout for RequestConfig.
diff --git a/pom.xml b/pom.xml
@@ -10,7 +10,7 @@
 	<groupId>com.github.docker-java</groupId>
 	<artifactId>docker-java</artifactId>
 	<packaging>jar</packaging>
-	<version>3.0.12-SNAPSHOT</version>
+	<version>3.1.0-SNAPSHOT</version>
 
 	<name>docker-java</name>
 	<url>https://github.com/docker-java/docker-java</url>
@@ -73,7 +73,7 @@
 		<!-- test dependencies -->
 		<logback.version>1.1.7</logback.version>
 		<testng.version>6.9.10</testng.version>
-		<netty.version>4.1.3.Final</netty.version>
+		<netty.version>4.1.11.Final</netty.version>
 		<hamcrest.library.version>1.3</hamcrest.library.version>
 		<hamcrest.jpa-matchers>1.8</hamcrest.jpa-matchers>
 		<lambdaj.version>2.3.3</lambdaj.version>
@@ -258,6 +258,12 @@
 			<version>${netty.version}</version>
 			<classifier>linux-x86_64</classifier>
 		</dependency>
+		<dependency>
+			<groupId>io.netty</groupId>
+			<artifactId>netty-transport-native-kqueue</artifactId>
+			<version>${netty.version}</version>
+			<classifier>osx-x86_64</classifier>
+		</dependency>
 		<dependency>
 			<groupId>junit</groupId>
 			<artifactId>junit</artifactId>
diff --git a/src/main/java/com/github/dockerjava/netty/NettyDockerCmdExecFactory.java b/src/main/java/com/github/dockerjava/netty/NettyDockerCmdExecFactory.java
@@ -1,5 +1,19 @@
 package com.github.dockerjava.netty;
 
+import static com.google.common.base.Preconditions.checkNotNull;
+
+import java.io.IOException;
+import java.net.InetAddress;
+import java.net.InetSocketAddress;
+import java.net.SocketAddress;
+import java.security.Security;
+
+import javax.net.ssl.SSLEngine;
+import javax.net.ssl.SSLParameters;
+
+import org.apache.commons.lang.SystemUtils;
+import org.bouncycastle.jce.provider.BouncyCastleProvider;
+
 import com.github.dockerjava.api.command.AttachContainerCmd;
 import com.github.dockerjava.api.command.AuthCmd;
 import com.github.dockerjava.api.command.BuildImageCmd;
@@ -142,6 +156,8 @@
 import io.netty.channel.EventLoopGroup;
 import io.netty.channel.epoll.EpollDomainSocketChannel;
 import io.netty.channel.epoll.EpollEventLoopGroup;
+import io.netty.channel.kqueue.KQueueDomainSocketChannel;
+import io.netty.channel.kqueue.KQueueEventLoopGroup;
 import io.netty.channel.nio.NioEventLoopGroup;
 import io.netty.channel.socket.DuplexChannel;
 import io.netty.channel.socket.SocketChannel;
@@ -249,6 +265,15 @@ private interface NettyInitializer {
     private class UnixDomainSocketInitializer implements NettyInitializer {
         @Override
         public EventLoopGroup init(Bootstrap bootstrap, DockerClientConfig dockerClientConfig) {
+            if (SystemUtils.IS_OS_LINUX) {
+                return epollGroup();
+            } else if (SystemUtils.IS_OS_MAC_OSX) {
+                return kqueueGroup();
+            }
+            throw new RuntimeException("Unspported OS");
+        }
+
+        public EventLoopGroup epollGroup() {
             EventLoopGroup epollEventLoopGroup = new EpollEventLoopGroup(0, new DefaultThreadFactory(threadPrefix));
 
             ChannelFactory<EpollDomainSocketChannel> factory = new ChannelFactory<EpollDomainSocketChannel>() {
@@ -258,14 +283,28 @@ public EpollDomainSocketChannel newChannel() {
                 }
             };
 
-            bootstrap.group(epollEventLoopGroup).channelFactory(factory)
-                    .handler(new ChannelInitializer<UnixChannel>() {
+            bootstrap.group(epollEventLoopGroup).channelFactory(factory).handler(new ChannelInitializer<UnixChannel>() {
+                @Override
+                protected void initChannel(final UnixChannel channel) throws Exception {
+                    channel.pipeline().addLast(new HttpClientCodec());
+                }
+            });
+            return epollEventLoopGroup;
+        }
+
+        public EventLoopGroup kqueueGroup() {
+            EventLoopGroup nioEventLoopGroup = new KQueueEventLoopGroup(0, new DefaultThreadFactory(threadPrefix));
+
+            bootstrap.group(nioEventLoopGroup).channel(KQueueDomainSocketChannel.class)
+                    .handler(new ChannelInitializer<KQueueDomainSocketChannel>() {
                         @Override
-                        protected void initChannel(final UnixChannel channel) throws Exception {
+                        protected void initChannel(final KQueueDomainSocketChannel channel) throws Exception {
+                            channel.pipeline().addLast(new LoggingHandler(getClass()));
                             channel.pipeline().addLast(new HttpClientCodec());
                         }
                     });
-            return epollEventLoopGroup;
+
+            return nioEventLoopGroup;
         }
 
         @Override
