Further separate out test cases

mislav · mislav · commit 4debbb17cd40 · 2021-06-11T14:32:08.000+02:00
diff --git a/pkg/cmd/factory/http_test.go b/pkg/cmd/factory/http_test.go
@@ -46,37 +46,53 @@ func TestNewHTTPClient(t *testing.T) {
 		{
 			name: "github.com no Accept header",
 			args: args{
-				config:     tinyConfig{"example.com:oauth_token": "MYTOKEN"},
+				config:     tinyConfig{"github.com:oauth_token": "MYTOKEN"},
 				appVersion: "v1.2.3",
 				setAccept:  false,
 			},
 			host: "github.com",
 			wantHeader: map[string]string{
-				"authorization": "",
+				"authorization": "token MYTOKEN",
 				"user-agent":    "GitHub CLI v1.2.3",
 				"accept":        "",
 			},
 			wantStderr: "",
 		},
+		{
+			name: "github.com no authentication token",
+			args: args{
+				config:     tinyConfig{"example.com:oauth_token": "MYTOKEN"},
+				appVersion: "v1.2.3",
+				setAccept:  true,
+			},
+			host: "github.com",
+			wantHeader: map[string]string{
+				"authorization": "",
+				"user-agent":    "GitHub CLI v1.2.3",
+				"accept":        "application/vnd.github.merge-info-preview+json",
+			},
+			wantStderr: "",
+		},
 		{
 			name: "github.com in verbose mode",
 			args: args{
 				config:     tinyConfig{"github.com:oauth_token": "MYTOKEN"},
 				appVersion: "v1.2.3",
-				setAccept:  false,
+				setAccept:  true,
 			},
 			host:     "github.com",
 			envDebug: "api",
 			wantHeader: map[string]string{
 				"authorization": "token MYTOKEN",
 				"user-agent":    "GitHub CLI v1.2.3",
-				"accept":        "",
+				"accept":        "application/vnd.github.merge-info-preview+json",
 			},
 			wantStderr: heredoc.Doc(`
 				* Request at <time>
 				* Request to http://<host>:<port>
 				> GET / HTTP/1.1
 				> Host: github.com
+				> Accept: application/vnd.github.merge-info-preview+json
 				> Authorization: token ████████████████████
 				> User-Agent: GitHub CLI v1.2.3
 				
