Merged
Conversation
Member
Author
clayreimann
approved these changes
Apr 9, 2019
Member
Author
|
@clayreimann Do you want me to merge from upstream master into my branch prior to merging? |
Member
|
@j-rewerts merge or rebase is fine with me. My first instinct is to squash merge for small PRs with more than 1 commit. |
I borrowed this strategy from the writeFile approach.
Codecov Report
@@ Coverage Diff @@
## master #547 +/- ##
=========================================
Coverage ? 90.79%
=========================================
Files ? 12
Lines ? 413
Branches ? 0
=========================================
Hits ? 375
Misses ? 38
Partials ? 0
Continue to review full report at Codecov.
|
j-rewerts
force-pushed
the
add-commit-author
branch
from
d25bc31 to
09f2042
Compare
Member
Author
|
@clayreimann Yeah feel free to squash and merge. |
This was referenced Jan 12, 2022
This was referenced Feb 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #546.
The commit function can now accept optional parameters for setting who the author or committer is. See here for GitHub's API on it.