Skip to content

set the expected result of the markdown GFM unit test to the right value#501

Closed
DanielRuf wants to merge 2 commits intogithub-tools:masterfrom
DanielRuf:fix-markdown-gfm-unit-test
Closed

set the expected result of the markdown GFM unit test to the right value#501
DanielRuf wants to merge 2 commits intogithub-tools:masterfrom
DanielRuf:fix-markdown-gfm-unit-test

Conversation

@DanielRuf
Copy link
Copy Markdown

@DanielRuf DanielRuf commented Mar 30, 2018

No description provided.

@DanielRuf DanielRuf changed the title set the expected result of the markdown gfm unit test to the right value set the expected result of the markdown GFM unit test to the right value Mar 30, 2018
@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 30, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@24223f7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #501   +/-   ##
=========================================
  Coverage          ?   91.06%           
=========================================
  Files             ?       12           
  Lines             ?      403           
  Branches          ?        0           
=========================================
  Hits              ?      367           
  Misses            ?       36           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24223f7...2f581aa. Read the comment docs.

@j-rewerts
Copy link
Copy Markdown
Member

j-rewerts commented Apr 5, 2019

I can confirm the result I got when running that test:

<p>Hello world <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="1012654" data-permission-text="Issue title is private" data-url="https://github.com/github/linguist/issues/1" data-hovercard-type="issue" data-hovercard-url="/github/linguist/issues/1/hovercard" href="https://github.com/github/linguist/issues/1">github/linguist#1</a> <strong>cool</strong>, and <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="183433" data-permission-text="Issue title is private" data-url="https://github.com/gollum/gollum/issues/1" data-hovercard-type="issue" data-hovercard-url="/gollum/gollum/issues/1/hovercard" href="https://github.com/gollum/gollum/issues/1">gollum#1</a>!</p>

@j-rewerts
Copy link
Copy Markdown
Member

j-rewerts commented Apr 5, 2019

I have it passing with this.

@j-rewerts j-rewerts mentioned this pull request Apr 5, 2019
Merged
@j-rewerts
Copy link
Copy Markdown
Member

j-rewerts commented Apr 7, 2019

@clayreimann We can close this.

@DanielRuf DanielRuf closed this Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DanielRuf @codecov-io @j-rewerts