Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Downloader hangs when executed with no items #877

Merged
shana merged 5 commits into from
Aug 1, 2018
Merged

Downloader hangs when executed with no items #877

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
675714a
Preventing queue execution if no items are added
StanleyGoldman Jul 31, 2018
1ea7925
Merge branch 'fixes/branch-list-test-ci-ignore' into fixes/empty-task…
StanleyGoldman Jul 31, 2018
e7c2a8c
Merge branch 'master' into fixes/empty-task-queue
StanleyGoldman Aug 1, 2018
ac93c49
Merge branch 'master' into fixes/empty-task-queue
StanleyGoldman Aug 1, 2018
801d033
Making sure to call base methods appropriately
StanleyGoldman Aug 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 40 additions & 8 deletions src/GitHub.Api/Tasks/ActionTask.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,31 @@ public ITask Queue(ITask task)

public override void RunSynchronously()
{
foreach (var task in queuedTasks)
task.Start();
if (queuedTasks.Any())
{
foreach (var task in queuedTasks)
task.Start();
}
else
{
aggregateTask.TrySetResult(true);
}

base.RunSynchronously();
}

protected override void Schedule()
{
foreach (var task in queuedTasks)
task.Start();
if (queuedTasks.Any())
{
foreach (var task in queuedTasks)
task.Start();
}
else
{
aggregateTask.TrySetResult(true);
}

base.Schedule();
}

Expand Down Expand Up @@ -115,15 +131,31 @@ public ITask<TTaskResult> Queue(ITask<TTaskResult> task)

public override List<TResult> RunSynchronously()
{
foreach (var task in queuedTasks)
task.Start();
if (queuedTasks.Any())
{
foreach (var task in queuedTasks)
task.Start();
}
else
{
aggregateTask.TrySetResult(new List<TResult>());
}

return base.RunSynchronously();
}

protected override void Schedule()
{
foreach (var task in queuedTasks)
task.Start();
if (queuedTasks.Any())
{
foreach (var task in queuedTasks)
task.Start();
}
else
{
aggregateTask.TrySetResult(new List<TResult>());
}

base.Schedule();
}

Expand Down