Add contributors on own line option #1004
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yykamei
reviewed
Sep 11, 2022
|
|
||
| user = issue["user"] | ||
| user = user(issue["user"]) | ||
| return "#{line} ({Null user})" unless user |
There was a problem hiding this comment.
GitHubChangelogGenerator::Section#user seems to only return String as far as I see, so I think this line is no longer needed.
Suggested change
| return "#{line} ({Null user})" unless user |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, folks! I'm investigating adopting this for ViewComponent. As I identified here, we'd need a few tweaks to do so and reflect the current changelog. This is one of them - my implementation feels a little bit sketchy so far, so I'd appreciate any advice I can get on how to comfortably have this sit alongside the current code.
At a glance, it'll take PRs from looking like this:
to this: