feat: use prefix variable for POWERTOOLS_SERVICE_NAME in Lambda functions #4948
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexalbu001
changed the title
alexalbu001
force-pushed
the
feat/use-prefix-for-powertools-service-name
branch
from
835b1a0 to
d82d6f7
Compare
npalm
requested changes
Dec 13, 2025
Member
npalm
left a comment
npalm
left a comment
There was a problem hiding this comment.
@alexalbu001 thx, can you also fix the following places in code as well.
- modules/runners/pool/main.tf
- modules/runners/ssm-housekeeper.tf
PR looks good.
alexalbu001
force-pushed
the
feat/use-prefix-for-powertools-service-name
branch
from
ffa0ba0 to
b02518c
Compare
Author
|
@npalm should be good now |
Member
|
Sorry for the late catch, but why do you think the service name should include the prefix as well. The initial idea was to set only the name of the service, since it is in context of the lambda the prefix is part of that. |
Author
|
I understand the design philosophy of keeping the service name as a logical identifier separate from the deployment context, however, I see a few benefits to including the prefix:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
POWERTOOLS_SERVICE_NAMEto use theprefixvariable instead of hardcoded values in pool, ami-housekeeper, scale-down, scale-up, webhook and dispatcher Lambda functions.Why
POWERTOOLS_SERVICE_NAMEshould too