Skip to content

Conversation

@edersonbrilhante
Copy link
Contributor

When I was running terragrunt plan in my deployment I noticed this warning

15:25:46.900 STDOUT tofu: │
15:25:46.900 STDOUT tofu: │   on .terraform/modules/ec2_runners.runners/modules/webhook/webhook.tf line 59, in module "direct":
15:25:46.900 STDOUT tofu: │   54:   config = {
15:25:46.900 STDOUT tofu: │   55:     lambda_subnet_ids                     = var.lambda_subnet_ids,
15:25:46.901 STDOUT tofu: │   56:     lambda_security_group_ids             = var.lambda_security_group_ids,
15:25:46.901 STDOUT tofu: │   57:     prefix                                = var.prefix,
15:25:46.901 STDOUT tofu: │   58:     tags                                  = var.tags,
15:25:46.901 STDOUT tofu: │   59:     runner_matcher_config                 = var.runner_matcher_config,
15:25:46.901 STDOUT tofu: │   60:     sqs_job_queues_arns                   = [for k, v in var.runner_matcher_config : v.arn]
15:25:46.901 STDOUT tofu: │   61:     lambda_zip                            = var.lambda_zip,
15:25:46.901 STDOUT tofu: │   62:     lambda_memory_size                    = var.lambda_memory_size,
15:25:46.901 STDOUT tofu: │   63:     lambda_timeout                        = var.lambda_timeout,
15:25:46.901 STDOUT tofu: │   64:     role_permissions_boundary             = var.role_permissions_boundary,
15:25:46.901 STDOUT tofu: │   65:     role_path                             = local.role_path,
15:25:46.901 STDOUT tofu: │   66:     logging_retention_in_days             = var.logging_retention_in_days,
15:25:46.901 STDOUT tofu: │   67:     logging_kms_key_id                    = var.logging_kms_key_id,
15:25:46.901 STDOUT tofu: │   68:     lambda_s3_bucket                      = var.lambda_s3_bucket,
15:25:46.901 STDOUT tofu: │   69:     lambda_s3_key                         = var.webhook_lambda_s3_key,
15:25:46.901 STDOUT tofu: │   70:     lambda_s3_object_version              = var.webhook_lambda_s3_object_version,
15:25:46.901 STDOUT tofu: │   71:     lambda_apigateway_access_log_settings = var.webhook_lambda_apigateway_access_log_settings,
15:25:46.901 STDOUT tofu: │   72:     repository_white_list                 = var.repository_white_list,
15:25:46.901 STDOUT tofu: │   73:     kms_key_arn                           = var.kms_key_arn,
15:25:46.902 STDOUT tofu: │   74:     log_level                             = var.log_level,
15:25:46.902 STDOUT tofu: │   75:     lambda_runtime                        = var.lambda_runtime,
15:25:46.902 STDOUT tofu: │   76:     aws_partition                         = var.aws_partition,
15:25:46.902 STDOUT tofu: │   77:     lambda_architecture                   = var.lambda_architecture,
15:25:46.902 STDOUT tofu: │   78:     github_app_parameters                 = var.github_app_parameters,
15:25:46.902 STDOUT tofu: │   79:     tracing_config                        = var.tracing_config,
15:25:46.902 STDOUT tofu: │   80:     lambda_tags                           = var.lambda_tags,
15:25:46.902 STDOUT tofu: │   81:     matcher_config_parameter_store_tier   = var.matcher_config_parameter_store_tier,
15:25:46.902 STDOUT tofu: │   82:     api_gw_source_arn                     = "${aws_apigatewayv2_api.webhook.execution_arn}/*/*/${local.webhook_endpoint}"
15:25:46.902 STDOUT tofu: │   83:     ssm_parameter_runner_matcher_config = [
15:25:46.902 STDOUT tofu: │   84:       for p in aws_ssm_parameter.runner_matcher_config : {
15:25:46.902 STDOUT tofu: │   85:         name    = p.name
15:25:46.902 STDOUT tofu: │   86:         arn     = p.arn
15:25:46.902 STDOUT tofu: │   87:         version = p.version
15:25:46.902 STDOUT tofu: │   88:       }
15:25:46.903 STDOUT tofu: │   89:     ]
15:25:46.903 STDOUT tofu: │   90:   }
15:25:46.903 STDOUT tofu: │
15:25:46.903 STDOUT tofu: │ The object type for input variable "config" does not include an attribute
15:25:46.903 STDOUT tofu: │ named "runner_matcher_config", so this definition is unused.
15:25:46.903 STDOUT tofu: │
15:25:46.903 STDOUT tofu: │ (and one more similar warning elsewhere)

This PR will remove invalid inputs when calling submodule direct in webhook

@edersonbrilhante edersonbrilhante requested a review from a team as a code owner December 11, 2025 15:01
@npalm
Copy link
Member

npalm commented Dec 11, 2025

Wondering any other problems with Tofu?

@edersonbrilhante
Copy link
Contributor Author

I am using just the module multi runner. It just showed these 2 inputs I removed. If there other modules not called by multi runner with similar issue, I can't tell

Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edersonbrilhante good catch!

@npalm npalm merged commit 79f26d6 into github-aws-runners:main Dec 13, 2025
41 checks passed
@edersonbrilhante edersonbrilhante deleted the fix-wrong-inputs branch December 15, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants