Skip to content

Add debugger opt-in feature flag#599

Merged
rentziass merged 7 commits into
debuggerfrom
rentziass/debugger-flag-impl
Jun 10, 2026
Merged

Add debugger opt-in feature flag#599
rentziass merged 7 commits into
debuggerfrom
rentziass/debugger-flag-impl

Conversation

@rentziass

Copy link
Copy Markdown
Member

Summary

  • gate the debugger command and adapter registration behind a manual settings.json opt-in
  • keep static debug-entry surfaces from failing silently by showing explicit opt-in/reload guidance
  • document the preview opt-in flow and reload requirement in the README

Validation

  • npm run lint
  • npm run build
  • npm test

rentziass and others added 2 commits June 10, 2026 09:16
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 10, 2026 08:16
@rentziass rentziass requested a review from a team as a code owner June 10, 2026 08:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a manual opt-in feature flag for the Actions Job Debugger, ensuring the debugger command/adapter are only registered when explicitly enabled, while still providing clear guidance via static debug-entry surfaces and README documentation.

Changes:

  • Gate debugger registration behind a settings.json opt-in (github-actions.debugger.enabled) and a desktop-only check.
  • Add a debug configuration provider guard to show explicit opt-in/reload messaging instead of failing silently.
  • Update the README to document the preview opt-in and reload flow, and adjust Command Palette visibility.
Show a summary per file
File Description
src/extension.ts Computes a desktop-only debuggerEnabled flag, sets a context key, and conditionally registers the debugger.
src/debugger/debugger.ts Adds a debug configuration provider guard for opt-in/reload messaging; tracks whether the debugger was registered.
src/configuration/configuration.ts Introduces isDebuggerEnabled() and prompts the user to reload when the debugger setting changes.
README.md Documents the opt-in setting, reload requirement, and updated command flow for the debugger preview.
package.json Removes onCommand activation for the debugger command and gates the command’s visibility behind a context key.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 5/5 changed files
  • Comments generated: 3

Comment thread src/configuration/configuration.ts Outdated
Comment thread package.json
Comment thread package.json
rentziass and others added 5 commits June 10, 2026 09:51
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@rentziass rentziass merged commit cd0318b into debugger Jun 10, 2026
1 check passed
@rentziass rentziass deleted the rentziass/debugger-flag-impl branch June 10, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants