Skip to content

Dispose event subscriptions in method modeling view #2882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
charisk merged 1 commit into from
Oct 2, 2023
Merged

Dispose event subscriptions in method modeling view #2882

charisk merged 1 commit into from
Oct 2, 2023

Conversation

@charisk
Copy link
Contributor

@charisk charisk commented Sep 28, 2023 •
edited
Loading

Now that the view provider is disposable, we can make sure we dispose of event subscriptions.

I suggest using "Hide whitespace" in the diff for easy of review.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from a team as a code owner September 28, 2023 15:17
@charisk
Copy link
Contributor Author

charisk commented Sep 29, 2023

This still has the same issue presented on #2891 but will be addressed separately.

norascheuch
norascheuch approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@norascheuch norascheuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@charisk charisk merged commit 58249e3 into main Oct 2, 2023
@charisk charisk deleted the charisk/dispose-subscriptions branch October 2, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@norascheuch norascheuch norascheuch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@charisk @norascheuch