Skip to content

Release v1.9.0 #2828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
robertbrignull merged 3 commits into from
Sep 19, 2023
Merged

Release v1.9.0 #2828

robertbrignull merged 3 commits into from
Sep 19, 2023

Conversation

@robertbrignull
Copy link
Contributor

@robertbrignull robertbrignull commented Sep 19, 2023

Minor version bump.

Updated the node version to 18.15.0 because this is the version used by VS Code as of 1.82. See https://code.visualstudio.com/updates/v1_82#_engineering

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested a review from a team September 19, 2023 09:18
@robertbrignull robertbrignull requested a review from a team as a code owner September 19, 2023 09:18
@robertbrignull
Copy link
Contributor Author

robertbrignull commented Sep 19, 2023 •
edited
Loading

CLI tests run: https://github.com/github/vscode-codeql/actions/runs/6234473652

@robertbrignull
Copy link
Contributor Author

robertbrignull commented Sep 19, 2023

We tried fixing the code by upgrading msw to the @next tag, but unfortunately we hit errors and decided it wasn't sensible to try to do that upgrade on the release branch. For now we're disabled the unit tests that are using the mock API server, and we'll look at upgrading msw, fixing the code, and re-enabling the tests as soon as we can after the release. In the meantime this should have no impact on users, except that the mock API server continues to be unusable on VS Code extension version 1.82 or higher.

koesie10
koesie10 approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertbrignull robertbrignull merged commit 297260a into main Sep 19, 2023
@robertbrignull robertbrignull deleted the v1.9.0 branch September 19, 2023 12:43
@robertbrignull robertbrignull mentioned this pull request Sep 20, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koesie10 koesie10 koesie10 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robertbrignull @koesie10