Skip to content

Ensure query history state is persisted after new query is added#1451

Merged
charisk merged 1 commit intomainfrom
charisk/query-history-persist
Aug 4, 2022
Merged

Ensure query history state is persisted after new query is added#1451
charisk merged 1 commit intomainfrom
charisk/query-history-persist

Conversation

@charisk
Copy link
Contributor

@charisk charisk commented Aug 3, 2022

Added refreshing of the tree view (which in turn persists the query history data on disk) when a new remote query is added. See internal issue for bug repro steps and context.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from a team as a code owner August 3, 2022 17:03
@charisk charisk added the secexp label Aug 4, 2022
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ✨

I hadn't hit this bug before, but I tested by running a few queries and restarting VS Code partway through, and all seems good! 💅🏽

@charisk charisk merged commit b8cca29 into main Aug 4, 2022
@charisk charisk deleted the charisk/query-history-persist branch August 4, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants