Replace code paths dropdown with VS Code UI Toolkit#1429
Merged
shati-patel merged 2 commits intomainfrom Jul 15, 2022
Merged
Conversation
shati-patel
commented
Jul 14, 2022
Comment on lines
99
to
101
| const selectedOption = event.target; | ||
| const selectedIndex = selectedOption.value; | ||
| setSelectedCodeFlow(codeFlows[selectedIndex]); |
Contributor
Author
There was a problem hiding this comment.
I'm aware this is could be written more concisely as
setSelectedCodeFlow(codeFlows[event.target.value]);But I found the verbose way easier to understand 😂 (React states are confusing 🙃 )
Contributor
There was a problem hiding this comment.
What you chose is exactly what I would have written!
aeisenberg
approved these changes
Jul 14, 2022
Contributor
aeisenberg
left a comment
aeisenberg
left a comment
There was a problem hiding this comment.
Either way, this looks good.
| </ActionMenu.Overlay> | ||
| </ActionMenu>; | ||
| return <VSCodeDropdown | ||
| onChange={(event: any) => { |
Contributor
There was a problem hiding this comment.
Minor: Is this type EventTarget in react? If it's easy to figure out, would be nice to have the proper type here.
charisk
approved these changes
Jul 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another step towards transitioning to the VS Code UI Toolkit! See internal issue for more details.
This PR replaces the dropdown in the "code paths" view with a more VS Code native one:
Checklist
ready-for-doc-reviewlabel there.