Merged
Conversation
elenatanasoiu
changed the title
elenatanasoiu
force-pushed
the
elenatanasoiu/node-18
branch
from
6058159 to
bd112e5
Compare
Contributor
|
If this works, it is much better than my approach. Also need to make sure the build still runs using node 16 (or at least the local build works). |
elenatanasoiu
force-pushed
the
elenatanasoiu/node-18
branch
from
bd112e5 to
5ce4bcb
Compare
A new release of source-map was pushed 10 days ago: https://github.com/mozilla/source-map/releases/tag/v0.7.4 It contains a fix for building on Node 18 (which was added in Oct 2020): mozilla/source-map#423. Let's make use of it!
We're upgrading the minimum version of webpack from 5.28.0 to 5.62.2 since this version doesn't rely on OpenSSL for its hashing algorithm so it wouldn't need legacy OpenSSL support when we decide to upgrade to Node 18. This allows us to build our extension on Node 18: https://github.com/github/vscode-codeql/runs/6904100934?check_suite_focus=true Happily, this also works fine with our current version of Node (16.13.0).
elenatanasoiu
force-pushed
the
elenatanasoiu/node-18
branch
from
5ce4bcb to
3264ffa
Compare
elenatanasoiu
changed the title
aeisenberg
approved these changes
Jun 15, 2022
Contributor
aeisenberg
left a comment
aeisenberg
left a comment
There was a problem hiding this comment.
Nice. Next step is to run our CI on both node 16 and node 18. That can come later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'd like to pave the way to upgrade from Node 16.13.0 (current version) to Node 18 (when VSCode decides to switch to it).
As we discovered in #1378, our build is currently breaking on Node 18 for two reasons:
source-map@0.7.3does not work on Node 18webpackrelies on OpenSSL for its hashing algorithm but OpenSSL is not supported by default from Node 17 onwards. While we can provide a legacy flag to revert to using OpenSSL in Node 18, this flag doesn't work with our current version of Node (16.13.0) and is actually re-activating insecure behaviour.To address these issues we're:
source-map@0.7.4which has very recently been released and works with Node 18webpackwhich doesn't rely on OpenSSLHappily, these packages run with both Node 16.13.0 and Node 18.
Checklist
ready-for-doc-reviewlabel there.