Skip to content

Fixed unique key warning#1169

Merged
charisk merged 1 commit intomainfrom
charisk/remove-unique-key-warning
Feb 25, 2022
Merged

Fixed unique key warning#1169
charisk merged 1 commit intomainfrom
charisk/remove-unique-key-warning

Conversation

@charisk
Copy link
Contributor

@charisk charisk commented Feb 25, 2022

Quick PR to remove a warning generated by the new Failures component

Warning: Each child in a list should have a unique "key" prop.
Check the render method of `Failures`. See https://reactjs.org/link/warning-keys for more information.
    at Failures (https://file+.vscode-resource.vscode-webview.net/Users/charisk/dev/vscode-codeql/extensions/ql-vscode/out/remoteQueriesView.js:39823:21)
    at Fe (https://file+.vscode-resource.vscode-webview.net/Users/charisk/dev/vscode-codeql/extensions/ql-vscode/out/remoteQueriesView.js:39163:17294)
    at ThemeProvider (https://file+.vscode-resource.vscode-webview.net/Users/charisk/dev/vscode-codeql/extensions/ql-vscode/out/remoteQueriesView.js:4155:3)
    at div
    at RemoteQueries (https://file+.vscode-resource.vscode-webview.net/Users/charisk/dev/vscode-codeql/extensions/ql-vscode/out/remoteQueriesView.js:39921:90)

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from a team as a code owner February 25, 2022 09:42
shati-patel
shati-patel approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! 🌹

@charisk charisk merged commit a5e0295 into main Feb 25, 2022
@charisk charisk deleted the charisk/remove-unique-key-warning branch February 25, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shati-patel shati-patel shati-patel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@charisk @shati-patel