Repository navigation
feat(workflows): expose verdict inputs on bundled review gates - #5391
Open
chelsealong wants to merge 1 commit into
Open
chelsealong wants to merge 1 commit into
chelsealong wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unchanged workflow versions block existing installations from receiving the fix through updates, and the tests use a nonportable command that causes failures on Windows without Unix utilities.
2 open issues
What changed in this PR
Addresses #5389 by allowing bundled workflow review gates to accept verdicts without a terminal, while preserving existing behavior when verdicts are omitted or empty.
Changes:
- Adds optional verdict inputs to the specification, plan, and assessment gates.
- Adds regression tests for pausing and resuming all three gates.
- Updates the shipped workflow example and non-interactive resume guidance.
Tests were not rerun during this review. AI disclosure: GitHub Copilot (model unknown, autonomous mode) generated this review for the requester.
| File | Description |
|---|---|
workflows/speckit/workflow.yml |
Adds and binds specification and plan verdict inputs. |
workflows/bugfix/workflow.yml |
Adds and binds the assessment verdict input. |
tests/workflows/test_bundled_gate_verdict_inputs.py |
Tests omitted, empty, and approving verdicts without a terminal. |
docs/workflows/developing.md |
Updates the example and explains verdict-based resume. |
Review effort: Balanced (auto)
|
|
||
| # Keep the shipped gate and input schema, replacing agent commands with a | ||
| # local shell step so this exercises CLI run/resume without an agent. | ||
| source["steps"] = [gate, {"id": "after", "type": "shell", "run": "true"}] |
Comment on lines
+38
to
+41
| spec_verdict: | ||
| type: string | ||
| enum: ["", approve, reject] | ||
| default: "" |
mnriem
added
the
triage-can-wait
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5389. Add optional
spec_verdict,plan_verdict, andassessment_verdictinputs to the corresponding bundled gates. Omitted or empty values preserve the existing pause behavior. Update the shipped workflow example in the documentation.Testing
.venv/bin/specify --help.venv/bin/python -m pytest— 13 passedThe new test failed on all three gates before the change with a missing
verdict_input. After the change, it verifies that each gate pauses without a verdict and completes afterresume --input ...=approve. Markdownlint, Ruff, andgit diff --checkpassed.AI Disclosure
AI disclosure: Implemented with Codex (GPT-6, default settings, autonomous mode) for workflow configuration, documentation, and regression test generation. No human review or testing is claimed.