Skip to content

Fix bug with marshalling experiments#259

Merged
zerowidth merged 3 commits intogithub:mainfrom
ridiculous:ridiculous-patch-1
Jun 17, 2024
Merged

Fix bug with marshalling experiments#259
zerowidth merged 3 commits intogithub:mainfrom
ridiculous:ridiculous-patch-1

Conversation

@ridiculous
Copy link
Contributor

@ridiculous ridiculous commented Mar 26, 2024 •
edited
Loading

Allows this to work:

Marshal.load(Marshal.dump(Scientist::Default.new("foo")))
#=> ArgumentError: wrong number of arguments (given 1, expected 0)
#=> from /Users/ryan.buckley/.rvm/gems/ruby-2.7.8@envoy-web/gems/scientist-1.6.3/lib/scientist/experiment.rb:334:in `marshal_load'

@zerowidth zerowidth merged commit 987f8be into github:main Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zerowidth zerowidth zerowidth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ridiculous @zerowidth