use plugins block for rubocop-performance and rubocop-rails#259
Conversation
There was a problem hiding this comment.
PR Overview
This PR updates the RuboCop configuration files to use the new "plugins" block for rubocop-performance and rubocop-rails, streamlining the configuration according to the updated guidelines.
- Adds a "plugins" block in config/rails.yml for rubocop-rails.
- Adds a "plugins" block in config/default.yml for rubocop-performance.
Reviewed Changes
| File | Description |
|---|---|
| config/rails.yml | Added "plugins" block to include rubocop-rails |
| config/default.yml | Added "plugins" block to include rubocop-performance |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
|
A new release should probably be cut to account for these changes |
There was a problem hiding this comment.
The docs for plugins say that it's only supported as of version 1.72. We should bump the required RuboCop version to account for this feature, if we ship it in default configurations, or otherwise make it optional? (And do a new release saying that this is breaking for apps that haven't upgraded to 1.72 yet.)
|
For development, this project is already at rubocop 1.72.2 it appears. I think bumping the required version of rubocop to 1.72 and publishing a new release for this Gem might be ideal. Just my opinion though. |
Co-authored-by: Koichi ITO <koic.ito@gmail.com>
3 participants
resolves: #258