Conversation
There was a problem hiding this comment.
PR Overview
This pull request adds build attestation steps to the release workflow to improve supply chain security for the rubocop-github Gem. Key changes include:
- Adding the "id-token" and "attestations" permissions to the workflow.
- Inserting a new step to attest the build provenance using the actions/attest-build-provenance action.
- Updating the release action to a newer pinned version.
Reviewed Changes
| File | Description |
|---|---|
| .github/workflows/release.yml | Updated permissions and added build attestation step; updated release action version. |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
.github/workflows/release.yml:42
- [nitpick] Consider using a semantic version tag for the 'actions/attest-build-provenance' action instead of a commit hash if a tag exists, to enhance clarity and maintainability.
- uses: actions/attest-build-provenance@520d128f165991a6c774bcb264f323e3d70747f4 # pin@v2
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
mattr-
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attest Build Provenance 🔒
This pull request publishes build attestations for the
rubocop-githubGem. This allows us and all downstream consumers to use the built in gh cli command to securely validate when/where the Gem was built and that GitHub (the trusted source) created it.Example 📸
Here is an example of how users of this gem can verify the gem after this PR lands:
$ gh attestation verify rubocop-github-X.X.X.gem --owner github