Merged
Conversation
elenatanasoiu
approved these changes
Oct 19, 2022
issyl0
force-pushed
the
upstream-erb-exclude-paths
branch
from
6a5a609 to
f899ecf
Compare
- Yes, by default Rails has `app/views/**/*.erb`, but ERB can also be elsewhere in the codebase. - This avoids users (of the Rails configs of this gem) from having to manually add other ERB exclusions, since these cops don't reliably play nicely with any ERB regardless of where it lives.
issyl0
force-pushed
the
upstream-erb-exclude-paths
branch
from
f899ecf to
5631e22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
app/views/**/*.erb, but ERB can also be elsewhere in the codebase.