Add contribution instructions, code of conduct, and codeowners#122
Merged
bensheldon merged 5 commits intomainfrom Oct 26, 2022
Merged
Add contribution instructions, code of conduct, and codeowners#122bensheldon merged 5 commits intomainfrom
bensheldon merged 5 commits intomainfrom
Conversation
bensheldon
changed the title
issyl0
reviewed
Oct 18, 2022
|
|
||
| This repository, `rubocop-github` is part of a broader RuboCop ecosystem. | ||
|
|
||
| If the Cop you would like to propose is **generally applicable outside of GitHub**: |
Member
There was a problem hiding this comment.
Should we be stronger here about only allowing contributions from GitHub staff? Maybe something like "we only accept new cop contributions if there's evidence they're applicable to and useful for GitHub's codebase". Not sure how external folks will provide that evidence.
Contributor
Author
There was a problem hiding this comment.
good flag! I'm willing to defer that until we see it. I'm not too worried that we'll be overwhelmed by contributions 😆
sampart
reviewed
Oct 26, 2022
Contributor
sampart
left a comment
sampart
left a comment
There was a problem hiding this comment.
Thanks so much for moving this forward ❤️ Just a quick grammar suggestion.
Co-authored-by: Sam Partington <sampart@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connects to #109.