Conversation
owenniblock
approved these changes
Jul 28, 2022
|
We should also update one of the config files so these accessibility rules are pulled in easily. Maybe config/default.yml? Or do you think it should be in an accessibility-specific one? Maybe a new |
khiga8
requested changes
Jul 28, 2022
khiga8
left a comment
khiga8
left a comment
There was a problem hiding this comment.
Could we create a new accessibility folder to house the accessibility rules?
This will ensure the file path reflects the module structure.
module RuboCop
module Cop
module GitHub
module Accessibility
Then the file names shouldn't include rails_
bolonio
deleted the
accessibility/issues/1430/migrate-a11y-rubocop-rules-image-has-alt
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The motivation of rubocop-github is to open-source our accessibility rubocop rules so non-GitHub people can benefit from them, have a space to provide comprehensive rule documentation, and also allow rules to be shared between Rails projects.
This PR migrates the accessibility rule
ImageHasAltfrom dotcom to rubocop-githubRelated Issue