Add event detail - eventType to 'remote-input-success' customEvent#34
Add event detail - eventType to 'remote-input-success' customEvent#34
Conversation
|
I was having trouble running testing locally due to dependencies being so old. I will keep trying locally but I was hoping the tests ran in the PR 😭 |
src/index.ts
Outdated
| const fetch = fetchResults.bind(null, this, true) | ||
| const state = {currentQuery: null, oninput: debounce(fetch), fetch, controller: null} | ||
| const fetch = (e: Event) => fetchResults.bind(null, this, true, e) | ||
| const state = {currentQuery: null, oninput: (e: Event) => debounce(fetch(e)), fetch, controller: null} |
There was a problem hiding this comment.
I think this would be better:
| const state = {currentQuery: null, oninput: (e: Event) => debounce(fetch(e)), fetch, controller: null} | |
| const state = {currentQuery: null, oninput: debounce((e: Event) => fetch(e)), fetch, controller: null} |
…com/github/remote-input-element into kendallg/add-event-detail-eventType
|
The PR to update linting and add it to the workflow that runs on pull requests: |
|
I am not authorized to merge this pull-request. Not sure if only Primer can... but this is good to go! |
jonrohan
left a comment
jonrohan
left a comment
There was a problem hiding this comment.
Seems good, only curious about the eslint dependency
| - name: Run build | ||
| run: npm run build | ||
| - name: Run test | ||
| run: npm run test |
There was a problem hiding this comment.
can't believe we weren't doing this already 🤦🏻
| "chai": "^4.1.2", | ||
| "chromium": "^3.0.3", | ||
| "eslint": "^6.8.0", | ||
| "eslint-plugin-github": "^3.4.1", |
There was a problem hiding this comment.
ah never mind, found the update pr 👍🏻
There was a problem hiding this comment.
Also, I am not authorized to merge so feel free to merge whenever.
4 participants
What
We need to announce the number of results when a remote-input has finished fetching results. This announcement should only happen on input
changeand therefore I need to know what triggered the 'remote-input-success' customEvent.Pairing with @TylerJDev to fix broken karma setup, ensure successful tests runs, and create a workflow to run the tests on PRs. He graciously offered to work on this pr as I became swamped on Thursday!