Add text/fragment+html to accept header#21
Merged
Conversation
keithamus
approved these changes
Jan 28, 2020
Contributor
keithamus
left a comment
keithamus
left a comment
There was a problem hiding this comment.
Refs github/auto-complete-element#36. Anyone looking for more context here should read github/auto-complete-element#36 (review)
muan
approved these changes
Jan 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out that
text/html; fragmentisn't a valid mimetype which causes some issues with gzip compression in nginx. Changing it to use the extensionfragmentin thetext/htmlmimetype should correct this oversight.This PR adds the
text/fragment+htmlmimetype to the accept header rather than straight replacing it so we can migrate github.com without downtime.